Support Laravel 9 #28
Conversation
|
@Olofguard I run the tests in my local and all passed. Looks like the docker image build is the only one failing. Please check. Thanks! 🎉
|
|
@Olofguard all checks are green here https://github.com/tenshiAMD/php-healthz/actions/runs/3169232332 |
| with: | ||
| path: /tmp/composer-cache | ||
| key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }} | ||
|
|
||
| - name: Install Dependencies | ||
| uses: php-actions/composer@master |
There was a problem hiding this comment.
Sorry have not had time to look at this. I wonder if it's because we're @master here for php-actions and master doesn't have 8 and 8.1 yet. Can you try uses: php-actions/composer@v6 looks like from the docs https://github.com/php-actions/composer#using-different-versions-of-php-or-composer @v6 and @v7 both have 8.1 support.
This is just a guess off the top of my head. This is the most i've been able to dig into this atm.
There was a problem hiding this comment.
@Olofguard I think the issues are the packages created by the workflow, you need to delete those and rerun the workflow. Here's the proof that all tests have passed. https://github.com/tenshiAMD/php-healthz/actions/runs/3169232332
There was a problem hiding this comment.
No actually looks the like issue is that on your branch it tries to push to our org which of course doesn't work as it's coming from your fork not from our repo. At least that's what I'm understanding atm. I'll investigate more when i have some more time.
Here's the error from the debug log
Successfully tagged docker.pkg.github.com/generationtux/php-healthz/php-actions_composer_php-healthz:php-8.0-build2
The push refers to repository [docker.pkg.github.com/generationtux/php-healthz/php-actions_composer_php-healthz]
663422d6247b: Preparing
692f464f5400: Preparing
e3026b9684d6: Preparing
0103c6155893: Preparing
e8a1531411ad: Preparing
b5ddaa9e9c6f: Preparing
744437e91ddb: Preparing
49a1a2a80ba6: Preparing
cd3f5d78e589: Preparing
994393dc58e7: Preparing
b5ddaa9e9c6f: Waiting
744437e91ddb: Waiting
49a1a2a80ba6: Waiting
cd3f5d78e589: Waiting
994393dc58e7: Waiting
denied: installation not allowed to Write organization package
|
@Olofguard hi, can you give this one some time? we need this package for one of our projects and we do not what to use our fork. Thanks! |
|
Yes as soon as i can i will. I apologize we just moved github actions for this repo and I have zero experience with it. I'll touch base with our engineer that set it up. |
@Olofguard sure however can you try updating the workflow similar to mine? and pushing it and let's see if it solves it since php-actions/composer require write permissions to create packages which I do not have. |
|
@Olofguard gentle ping |
|
@Olofguard please check |
|
Tested these changes on my own branch and it passed. Im just going to merge it, it should pass when it's in master under our org. |
Fixes #27.
Laravel 9 requires PHP 8.0 or latest and
"guzzlehttp/guzzle": "^7.2". Checkout https://github.com/laravel/framework/blob/da859e7c1d67278d79ad95410c7656e6b4f8e7be/composer.json#L89.