Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactome release 82 models from geneontology/reactome-go-cams#9 #247

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

dustine32
Copy link
Contributor

Drop-N-Reload of Reactome models in Noctua production using Reactome release 82 data. Models are from geneontology/reactome-go-cams#9. @ukemi and @deustp01 have tested these in noctua-dev as noted in geneontology/pathways2GO#176 (comment).

Hopefully this can be pulled in during the 2022-11-10 Noctua outage?

@dustine32
Copy link
Contributor Author

Noting an issue spotted by @ukemi but it doesn't block this PR from going in. The group search does not work for these models and I figured out that it's due to "https" in each model's providedBy vs "http" in groups.yaml:
image
image
@deustp01 @ukemi Which do you prefer, "http" or "https"?
We'll make a ticket in the appropriate repo (depends on the answer) and plan to get this in on the next load.

@ukemi
Copy link

ukemi commented Nov 8, 2022

When I navigate to Reactome it is https. I guess that would be the correct one. You probably know better than I. :)

@kltm
Copy link
Member

kltm commented Nov 8, 2022

If this data has not leaked elsewhere (remember that these are identifiers, not URLs), it would be good to get them onto the one with a more likely future: https.

@deustp01
Copy link

deustp01 commented Nov 8, 2022

https should be right.

Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gunna go with whatever @dustine32 sez here

@kltm kltm merged commit d490d19 into master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants