Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix range formatting #89

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Fix range formatting #89

merged 5 commits into from
Nov 13, 2024

Conversation

NP4567-dev
Copy link
Collaborator

Fixes #83

Moved logger, exceptions and range_value to utils

Let me know if you need anything changed :)

Copy link
Member

@samuelrince samuelrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the changes. One remark, I'd rather keep log.py and exceptions.py in the package root.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the test file to tests/ directory and rename to test_range_value.py.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the directory utils/ in tests/

@samuelrince samuelrince merged commit 418cbf2 into genai-impact:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support formatting for Range values
2 participants