Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Range Values #55

Merged
merged 19 commits into from
Jul 1, 2024
Merged

Implement Range Values #55

merged 19 commits into from
Jul 1, 2024

Conversation

samuelrince
Copy link
Member

The main goal of this PR is to add Range object to model intervals. It integrates with Impact data model and can be compared or added with integers and floats.

Added

  • Range model
  • Tests of Impact models
  • Environmental impacts tutorial page

Changed

  • Separate compute_llm_impacts function into two functions, compute_llm_impacts_dag that returns raw results and compute_llm_impacts that returns the Impacts model.
  • request_latency is now an optional parameter of compute_llm_impacts
  • compute_llm_impacts from tracer.utils is now llm_impacts

@samuelrince samuelrince requested a review from adrienbanse June 28, 2024 15:39
Copy link
Member

@adrienbanse adrienbanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samuelrince, it's good to go for me. Let me just specify the units of the latency in the code so that we can close #49 with this PR.

docs/tutorial/impacts.md Show resolved Hide resolved
ecologits/impacts/modeling.py Outdated Show resolved Hide resolved
ecologits/impacts/modeling.py Outdated Show resolved Hide resolved
@adrienbanse
Copy link
Member

@samuelrince Ready for merging 🍾

@samuelrince samuelrince merged commit 3f96724 into main Jul 1, 2024
2 checks passed
@samuelrince samuelrince deleted the feat/parameter-range branch July 1, 2024 15:23
@adrienbanse adrienbanse mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants