generated from dataforgoodfr/d4g-project-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confidence intervals from linear regression #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Optional) Following @NP4567-dev PR we can include an uncertainty mode in the config |
samuelrince
requested changes
Feb 12, 2025
Also, let's not include the configuration part for now, I have reverted it temporarily! |
samuelrince
approved these changes
Feb 13, 2025
All good for me @adrienbanse, thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #95, for each value that is a result of a linear regression, we explicitely compute uncertainty and provide 95% confidence intervals with
y = f(x) +- 1.96 * std_dev
.In the context of the computed impacts, the standard deviations for both the energy and the latency have been computed in https://github.com/genai-impact/methodology/blob/main/lab/lin_reg.ipynb. The impacts that depend on these values are therefore
ValueRange
, and notfloat
orint
such as before.This PR also adds somes tests for
ValueRange
, as__mul__
and__truediv__
operations were implented.Remains to