Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confidence intervals from linear regression #104

Merged
merged 9 commits into from
Feb 13, 2025

Conversation

adrienbanse
Copy link
Member

@adrienbanse adrienbanse commented Dec 20, 2024

Following #95, for each value that is a result of a linear regression, we explicitely compute uncertainty and provide 95% confidence intervals with y = f(x) +- 1.96 * std_dev.

In the context of the computed impacts, the standard deviations for both the energy and the latency have been computed in https://github.com/genai-impact/methodology/blob/main/lab/lin_reg.ipynb. The impacts that depend on these values are therefore ValueRange, and not float or int such as before.

This PR also adds somes tests for ValueRange, as __mul__ and __truediv__ operations were implented.

Remains to

  • Update the doc

@adrienbanse adrienbanse marked this pull request as ready for review February 5, 2025 17:11
@adrienbanse adrienbanse marked this pull request as ready for review February 8, 2025 13:12
@adrienbanse
Copy link
Member Author

(Optional) Following @NP4567-dev PR we can include an uncertainty mode in the config

@samuelrince
Copy link
Member

Also, let's not include the configuration part for now, I have reverted it temporarily!

@samuelrince
Copy link
Member

samuelrince commented Feb 13, 2025

All good for me @adrienbanse, thanks for this PR!

@adrienbanse adrienbanse merged commit ba53719 into main Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants