Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix swc warning #993

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: fix swc warning #993

merged 1 commit into from
Aug 9, 2024

Conversation

Kabir-Ivan
Copy link
Collaborator

No description provided.

@@ -22,6 +22,7 @@ export const tryToRegisterTsNode = (): void => {

if (JSON.parse(swcRaw)) {
try {
require("@swc/core");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require @swc/core to get an error with code "MODULE_NOT_FOUND" if it is not installed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way testplane: you may install @swc/core for significantly faster reading of typescript tests. will be shown

@Kabir-Ivan Kabir-Ivan requested a review from shadowusr August 8, 2024 15:05
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename the isWorker param to isSilent. Other than that, looks good to me.

@Kabir-Ivan Kabir-Ivan merged commit d86460a into master Aug 9, 2024
2 checks passed
@Kabir-Ivan Kabir-Ivan deleted the fix-swc branch August 9, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants