-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retry logic because of new runners' API #19
Conversation
8b06928
to
b58501f
Compare
_getTestsToRetry: function() { | ||
return _(this._matchers) | ||
.groupBy('browser') | ||
.mapValues(function(item) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item
->matchers
🆗 |
@@ -5,7 +5,7 @@ | |||
"main": "lib/hermione.js", | |||
"scripts": { | |||
"lint": "jshint . && jscs .", | |||
"test-unit": "istanbul test _mocha -- --recursive test/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почему эта опция не нужна?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
смотри ниже, он ее в опции mocha
перенес
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не досмотрел :(
Linked with supporting of sets.
/cc @sipayRT @j0tunn