fix: fix client code to work on IE11 (#812)

gemini-testing · Nov 29, 2023 · 197e057 · 197e057
1 parent 40b2917
commit 197e057
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/browser/client-scripts/index.js b/src/browser/client-scripts/index.js
@@ -177,7 +177,8 @@ function disableFrameAnimationsUnsafe() {
 
     window.__cleanupAnimation = function () {
         for (var i = 0; i < styleElements.length; i++) {
-            styleElements[i].remove();
+            // IE11 doesn't have remove() on node
+            styleElements[i].parentNode.removeChild(styleElements[i]);
         }
 
         delete window.__cleanupAnimation;

diff --git a/src/browser/client-scripts/util.js b/src/browser/client-scripts/util.js
@@ -93,7 +93,8 @@ exports.forEachRoot = function (cb) {
     function traverseRoots(root) {
         cb(root);
 
-        var treeWalker = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT);
+        // In IE 11, we need to pass the third and fourth arguments
+        var treeWalker = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT, null, false);
 
         for (var node = treeWalker.currentNode; node !== null; node = treeWalker.nextNode()) {
             if (node instanceof Element && node.shadowRoot) {

diff --git a/src/browser/commands/scrollIntoView.ts b/src/browser/commands/scrollIntoView.ts
@@ -14,7 +14,9 @@ export = async (browser: Browser) => {
             options: ScrollIntoViewOptions | boolean = { block: "start", inline: "nearest" },
         ): Promise<void> {
             await session.execute<Promise<void>, [WebdriverIO.Element, ScrollIntoViewOptions | boolean]>(
-                (elem, options) => elem.scrollIntoView(options),
+                function (elem, options) {
+                    return elem.scrollIntoView(options);
+                },
                 this,
                 options,
             );