-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #10 with the addition of a transparency
option
#30
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you use alpha channel in compare functions so you need to do it in antialiasing too. It's embarrassing that in different places we are compare images in different way
@chrisdeely are you planning to update your PR according to requested changes? If not, I can do it :) This feature will be very handy! |
@kisenka I'll happily let you take the reigns here! I obviously have not gotten back to this in a timely manner |
Could this provide a fix for #59 ? |
I know this is a few years old, but is there anyway to merge this in? I don't know much about the library but I'll help if possible. I'm working on a visual change detection app for websites and transparency would really help me! |
@JoshuaM1995 that would be lovely! there has been some activity in this repo recently, so maybe it'll happen! |
Hello guys. I will try to look at this on this week. |
… control the alpha of unchanged pixels
i'm taking a look at this - the repo has moved on quite a bit since I initially made this PR, I'll see if I can adapt it to the new style |
0dae96a
to
5543015
Compare
I have updated my branch to re-implement this feature according to the new code style & features. the tests are all passing and the new Since the library now supports more image formats than just png, the alpha channel is defaulted to I have not tested the impact on antialiasing detection, but if there are issues there, please let me know and I'll try to help out. |
Uses a
matchingPixelAlpha
option forlooksSame.createDiff
to control the alpha of unchanged pixels.This necessitated including the alpha channel in color comparisons in order to properly validate the diif images are rendered properly.