resources: add packer files to make x86 and arm npb image #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin-le
reviewed
Sep 4, 2024
erin-le
reviewed
Sep 12, 2024
erin-le
reviewed
Sep 12, 2024
This commit adds to build-arm.sh so the commands to get flash0.img work and also removes arguments from arm-npb.pkr.hcl so that the image will build.
erin-le
reviewed
Sep 12, 2024
erin-le
reviewed
Sep 12, 2024
Co-authored-by: Erin (Jianghua) Le <[email protected]>
erin-le
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM. I tested building both disk images and used them as resources to run UA size s. I had some trouble writing/getting the config scripts to work, so it could be a good idea to add example scripts for these disk images in configs/example/gem5_library, then update the documentation to point to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npbdirectory tonpb-24.04-imgspost-install.shthat are required by the image to build the NPB benchmarks