Add with-unknown-type #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
approved these changes
May 6, 2020
| | EPrimTypeMacro (SplitTypePtr -> Syntax -> Expand ()) (TypePatternPtr -> Syntax -> Expand ()) | ||
| -- ^ For type-level special forms - first as types, then as type patterns | ||
| | EPrimModuleMacro (Syntax -> Expand ()) | ||
| | EPrimDeclMacro (DeclTreePtr -> DeclOutputScopesPtr -> Syntax -> Expand ()) | ||
| | EPrimPatternMacro (Either (Ty, Ty, PatternPtr) (Ty, TypePatternPtr) -> Syntax -> Expand ()) | ||
| | EPrimUniversalMacro (MacroDest -> Syntax -> Expand ()) |
There was a problem hiding this comment.
What is a "universal" macro?
There was a problem hiding this comment.
Universal in the sense that it works in any syntactic context, be it expression, type, decl, etc.
There was a problem hiding this comment.
What is its meaning in a pattern context? Looks like an error? And in a declaration context? What about a module context? (Not trying to be annoying, just trying to understand 😄)
|
Universal in the sense that it works in any syntactic context, be it
expression, type, decl, etc.
…On Wed, May 6, 2020, 07:37 Langston Barrett ***@***.***> wrote:
***@***.**** approved this pull request.
Love the small PR 😄
------------------------------
In src/Expander/Monad.hs
<#71 (comment)>:
> | EPrimTypeMacro (SplitTypePtr -> Syntax -> Expand ()) (TypePatternPtr -> Syntax -> Expand ())
-- ^ For type-level special forms - first as types, then as type patterns
| EPrimModuleMacro (Syntax -> Expand ())
| EPrimDeclMacro (DeclTreePtr -> DeclOutputScopesPtr -> Syntax -> Expand ())
| EPrimPatternMacro (Either (Ty, Ty, PatternPtr) (Ty, TypePatternPtr) -> Syntax -> Expand ())
+ | EPrimUniversalMacro (MacroDest -> Syntax -> Expand ())
What is a "universal" macro?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#71 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4FAX3HQ2WPCQ2KI45NVTRQFYYZANCNFSM4M2D6UAQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is half of #60. See that issue for a description of the new operator.