Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Remove @types/chai-http dependency #946

Closed
wants to merge 21 commits into from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 31, 2018

Description:

chai-http ships typescript definitions now (chaijs/chai-http#221). Should be safe to drop the extra package.

@kesselb kesselb requested review from Gargamil and dboschm October 31, 2018 13:44
@coveralls
Copy link

coveralls commented Oct 31, 2018

Pull Request Test Coverage Report for Build 397

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.1%

Totals Coverage Status
Change from base Build 395: 0.0%
Covered Lines: 1719
Relevant Lines: 2243

💛 - Coveralls

@kesselb kesselb requested a review from torss October 31, 2018 21:40
@dboschm
Copy link
Collaborator

dboschm commented Nov 1, 2018

wait for chaijs/chai-http#230 before merge

@dboschm dboschm added the blocked This Issue is blocked or can't be solved yet label Nov 1, 2018
@dboschm dboschm added the dependencies Pull requests that update a dependency file label Nov 9, 2018
@dboschm dboschm added blocked This Issue is blocked or can't be solved yet and removed blocked This Issue is blocked or can't be solved yet labels Nov 22, 2018
@dboschm dboschm removed the blocked This Issue is blocked or can't be solved yet label Jan 5, 2019
Copy link
Collaborator

@dboschm dboschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kesselb
Copy link
Contributor Author

kesselb commented Jan 5, 2019

Closed by #1099

@kesselb kesselb closed this Jan 5, 2019
@kesselb kesselb deleted the bugfix/remove-types-chai-http branch January 5, 2019 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants