fix: Event summaries no longer get quotes over-escaped #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katjam
reviewed
Aug 15, 2024
|
|
||
| if as_plaintext | ||
| doc.text |
There was a problem hiding this comment.
Is this actually doing anything?
There was a problem hiding this comment.
yes - its an implicit return
katjam
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slight mis-scoping that was causing plain text strings to get re-encoded. This PR means that if
as_plaintextis true, it doesn't get sent back through Kramdown before being saved.I am lost how to write tests for this but have verified it working locally.
Fixes #1773