Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix og:image on partners with no image set #2508

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

kimadactyl
Copy link
Member

@kimadactyl kimadactyl commented Jun 13, 2024

Oversight in the conditional is resulting in the default og image, not the site one, showing up if the partner does not have an image set.

Fixes #2491

@kimadactyl kimadactyl requested a review from katjam June 13, 2024 11:05
@kimadactyl kimadactyl enabled auto-merge (squash) June 13, 2024 11:10
@kimadactyl kimadactyl merged commit 767c297 into main Jun 19, 2024
2 checks passed
@kimadactyl kimadactyl deleted the fix-partner-og-image branch June 19, 2024 13:41
@honor-gfsc
Copy link

verified
Screenshot 2024-06-24 at 16 54 50

@honor-gfsc honor-gfsc added the verified Issues that have been user acceptance tested label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified Issues that have been user acceptance tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve our open graph previews
2 participants