Fix wrong internet providers showing up

[kimadactyl]

• Adds byebug gem back into test gems so you can console out of a test (as suggested by the official docs).
• Removes faulty :for_site_with_tag method, just chain :for_site and :with_tags instead
• Update tests

Note I am not 100% confident the tests are doing what they should be doing. They're hard to interpret and read and are deffo due a refactor - factories are adding in way too much context. I've tested this manually a bunch for now though.

Fixes #2365

[katjam]

Just double checking if we need to add that visibility check back in. Otherwise looks ok to try.

[katjam]

Do we need to add the visible flag back in to this query?

[kimadactyl]

Good thinking - looks like the for_site method does check visibility too tho. Which does raise the question if it should - but poss a tech debt question for antoher day?

[katjam]

One more teeny thought is that actually we do maybe want to show partners by just area in those sections - because internet & wifi access are kind of agnostic of interest group. But maybe also this is a safeguarding issue?

[kimadactyl]

I think the logic here breaks down a bit for interest-based groups over wider areas, and I don't think we should have partners listed that aren't visible on the main partners page, that just sounds confusing.

Might be more interesting to think about making these blocks modular and togglable? Let's keep an eye out for if anything that comes up that people are looking to highlight?

[honor-gfsc]

I think this should be verified by someone with more technical knowledge

[kimadactyl]

validated working on:

• hulme
• moss side
• gmsc (no listings)
• norwich (no listings)
• manchester
• torbay