Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple create partner form #2412

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

aaaaargZombies
Copy link
Contributor

@aaaaargZombies aaaaargZombies commented Apr 17, 2024

fixes #970

  • just essential details for partner creation on the new partner form
  • redirects to full form / edit page after creation

notes

I added in partnerships to the AC / form because if a partnership_admin creates a partner without connecting to their partnership they will not be able to access them (I think it also fails verification). This only shows for partnership_admins and roots.

It wasn't specified in the AC but I removed the setup related code as this is now a duplicate of new

@aaaaargZombies aaaaargZombies requested a review from a team April 17, 2024 17:51
@ivan-kocienski-gfsc ivan-kocienski-gfsc requested review from ivan-kocienski-gfsc and removed request for a team April 18, 2024 07:59
Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Nice work removing the setup thing.

@aaaaargZombies aaaaargZombies merged commit 4baaf67 into main Apr 18, 2024
2 checks passed
@aaaaargZombies aaaaargZombies deleted the 970-simple-create-partner-form branch April 18, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the create partner form more user friendly
2 participants