More secure feedback message on password reset #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a password reset account is found (or not) show the same feedback message. This way no private information is being leaked in public.
…alchange/PlaceCal into ik-2225-stop-leaking-emails
|
This doesn't match the AC but I think the PR does solve the original probelm |
|
I fixed the A/C so this is okay (and it is okay) The important thing is that we verify we aren't potentially leaking any information here |
aaaaargZombies
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2225
If a password reset account is found (or not) show the same feedback message. This way no private information is being leaked in public.
The reset now looks like this regardless of whether or not the email exists:
I also checked the log in page and confirmed that does not have the same problem (the message is always the same for either email or password)