Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support section to sidebar in admin ui #2390

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

aaaaargZombies
Copy link
Contributor

@aaaaargZombies aaaaargZombies commented Apr 12, 2024

fixes #2146

Added all the suggested links into the sidebar and moved the report a bug link in there too, I wrote the AC as appearing for admins but I included roots in this too as there seemed no harm in it and being familiar with what other users will see will make it easier to advice / support people.

2024-04-12-11:07:01-screenshot

@aaaaargZombies aaaaargZombies requested a review from a team April 12, 2024 10:19
@kimadactyl
Copy link
Member

kimadactyl commented Apr 15, 2024

I think this looks great, my only q is how do people feel about mailto: links? I feel like for me they are a bit of very old fashioned tech that often results in my mail client opening and trying to run me through a setup wizard. Maybe it should just be a plain text email address? Prob ideally it would take you to a web form inside PlaceCal that fills in extra details for us automatically actually, but one for another day.

I think if we keep the mailto link at least lets make the text the email address rather than "email us" so u don't have to mouse over to find the info?

@aaaaargZombies
Copy link
Contributor Author

I think the problem of not using mailto: in a link in a link tag is an email isn't a valid url and it breaks like this

image

we could just leave it as text?

@kimadactyl
Copy link
Member

yeah i was advocating for removing the link completely and just tell people the email. fine if others disagree ofc! ive just litearlly never found this function to be welcome personally.

@katjam
Copy link
Member

katjam commented Apr 15, 2024

Agree with kim. Plan text is perfect and more usable.

@aaaaargZombies
Copy link
Contributor Author

I see! That makes sense, it's implemented now

image

@kimadactyl
Copy link
Member

kimadactyl commented Apr 15, 2024

this still has the "email us" link in - need to remove?

also looks a bit out of place in the menu - would it make sense to move it into the small text below the build number?

@aaaaargZombies
Copy link
Contributor Author

whoops took the screenshot too soon

you can see it's removed in the code here

    <h6 class="sidebar-heading d-flex justify-content-between align-items-center px-3 mt-4 mb-1 text-muted">
      <span>Get support</span>
    </h6>
    <%= admin_nav_link('Handbook', 'https://handbook.placecal.org/', 'book')%>
    <li class="nav-item"><span class="nav-link"><i class="fa fa-envelope feather"></i>[email protected]</span></li>
    <%= admin_nav_link('Discord', 'http://discord.gfsc.studio/', 'comment')%>
    <%= admin_nav_link('Report a bug', 'https://github.com/geeksforsocialchange/PlaceCal/issues/new?assignees=&labels=&template=bug_report.md', 'bug')%>

view code in context

@aaaaargZombies
Copy link
Contributor Author

image

@aaaaargZombies
Copy link
Contributor Author

also looks a bit out of place in the menu - would it make sense to move it into the small text below the build number?

I really think we should have all the get support stuff in one place not scattered around the shop - I felt "email us" looked more in keeping but as you and Katja say maybe less practical.

@kimadactyl
Copy link
Member

ok i see what you did now didnt take it in properly, agreed looks good. could maybe just put it at the top or bottom of the list but otherwise all cool!

@aaaaargZombies
Copy link
Contributor Author

It's in the bottom of the list for non-root users, the bottom of the list is all that stuff that should probably be ignored because we aren't working on it, collections etc.

@kimadactyl
Copy link
Member

sorry i specifically mean put the email link at the top or bottom of the list - itll prob look a bit more balanced to go "ABBB" than "ABAA"

@aaaaargZombies
Copy link
Contributor Author

OK I think we might be on the home straight

image

@aaaaargZombies aaaaargZombies merged commit 88ed3f6 into main Apr 15, 2024
2 checks passed
@aaaaargZombies aaaaargZombies deleted the 2146-improve-support-pathways-for-admins branch April 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it clear where partners can go for help with tech problems
3 participants