Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rollbar gem #2369

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Updated rollbar gem #2369

merged 1 commit into from
Apr 8, 2024

Conversation

ivan-kocienski-gfsc
Copy link
Contributor

Closes #2367

Bit of a rabbit hole this one: when visiting unknown routes like /foofoofoo or /styleguide/styleguide/event the server would 500 with no backtrace (probably because there was an error in the error handler).

Turns out the rollbar gem (v3.3.0) likely had a bug in it that is fixed in the latest version (v3.5.2)

@ivan-kocienski-gfsc ivan-kocienski-gfsc requested a review from a team April 8, 2024 08:31
Copy link
Contributor

@aaaaargZombies aaaaargZombies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the dev 404 screen so presumably we'll get something not crashy in staging / production

image

Either way good to update this gem and I'm surprised it's having this effect.

@ivan-kocienski-gfsc ivan-kocienski-gfsc merged commit cabb64a into main Apr 8, 2024
2 checks passed
@ivan-kocienski-gfsc ivan-kocienski-gfsc deleted the ik-2367-crashing-404-pages branch April 8, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 404 pages crash
2 participants