Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle optional hero image #2340

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

aaaaargZombies
Copy link
Contributor

@aaaaargZombies aaaaargZombies commented Mar 26, 2024

fixes #2329

check if image is there before adding image element.

image

image

image

Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aaaaargZombies aaaaargZombies merged commit 4cf2b95 into main Mar 29, 2024
2 checks passed
@aaaaargZombies aaaaargZombies deleted the 2329-handle-optional-hero-image branch March 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sites without images set have a huge whitespace area
2 participants