Lint stylesheets #2244
Merged
Lint stylesheets #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for linting with prettier
- default make task runs prettier scss lint - removed uneeded config
r-ferrier
reviewed
Feb 14, 2024
There was a problem hiding this comment.
This is so cool! The only comment I have is that now we've properly formatted everything, I'm noticing that having indentation with 4 spaces is maybe making it a bit harder for me to see the shapes of the css blocks - I wonder if want to change to 2 spaces over 4 for indentation? @aaaaargZombies what do you think?
|
Hmm, for me it is 8 spaces. Looking in the But I am happy to (try) configuring it to 2 spaces |
|
For future me: we may want to use {
"useTabs": false,
"tabWidth": 2,
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1455
Have converted stylesheets over to SCSS as this can be picked up by Prettier (stylesheet linting) and therefore runs as part of the precommit hook.
Have not implemented a check to see if any SASS files are in the repo so we have to agree to not use SASS any more.