Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show admins the sites this partner appears on #2236

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

ivan-kocienski-gfsc
Copy link
Contributor

Closes #2231

This is just a list of links to the sites (as the original behaviour) not links to the partner page of that site.

Copy link
Contributor

@r-ferrier r-ferrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I appreciate this wasn't clear from the issue but I just meant for all the metadata at the top of the partner to be visible to all admin users, and not just roots. If you could remove the root restriction for the rest of it this will be good to go.

Copy link
Contributor

@r-ferrier r-ferrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ivan-kocienski-gfsc ivan-kocienski-gfsc merged commit d4b0f71 into main Feb 1, 2024
2 checks passed
@ivan-kocienski-gfsc ivan-kocienski-gfsc deleted the ik-2231-partner-site-list branch February 1, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show information about which sites a partner appears on to all users with view permission for that partner
2 participants