Mute rollbar routing error warnings #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kocienski-gfsc
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1666
Description
We're still logging tonnes of routing error warnings every month which is causing us to burn through our rollbar allowance in a few days.
The previous solution was only firing for specific 'bad' routes, but every route that ends in a 404 is a bad route and we're getting such a wide variety of them through that for now, just muting all of them is more useful to our error logging than trying to pick and choose which we care about.
As an example, here are all the errors that were logged this morning:
We should probably also look at serving a 404 page/ rerouting to home instead of just raising this error! (#759)