Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide untagged partner admins from partnership admins #2209

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Hide untagged partner admins from partnership admins #2209

merged 5 commits into from
Jan 23, 2024

Conversation

r-ferrier
Copy link
Contributor

@r-ferrier r-ferrier commented Jan 23, 2024 •
edited
Loading

Fixes #2169

Description

  • Shows partnership admins only users that are partner admins for partners within their scope
  • Adds some user policy tests to assert the scope is behaving as it should

@aaaaargZombies aaaaargZombies self-assigned this Jan 23, 2024
ivan-kocienski-gfsc
ivan-kocienski-gfsc approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aaaaargZombies aaaaargZombies removed their assignment Jan 23, 2024
@r-ferrier r-ferrier merged commit be864f5 into main Jan 23, 2024
2 checks passed
@r-ferrier r-ferrier deleted the feat/2169-hide-untagged-partner-admins-from-partnership-admins branch January 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-kocienski-gfsc ivan-kocienski-gfsc ivan-kocienski-gfsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partnership admins can only see users that admin for a partner they can view
3 participants
@r-ferrier @ivan-kocienski-gfsc @aaaaargZombies