Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused gems #2190

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Removing unused gems #2190

merged 2 commits into from
Jan 18, 2024

Conversation

ivan-kocienski-gfsc
Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc commented Jan 17, 2024 •
edited
Loading

Closes #2162

Removed unused gems

Important notes when merged in

I found running these commands where necessary to expunge the old gems / assets from being loaded (during tests):

rbenv gemset delete 3.1.2 gfsc-placecal # purge old/unused gems
bundle
rails assets:clobber # force clean assets
rails tmp:cache:clear # will remove coffee script remnants

Important notes when deploying

The rails tmp:cache:clear may have to be run prior to deployment to staging / production.

@ivan-kocienski-gfsc ivan-kocienski-gfsc requested a review from a team January 17, 2024 23:56
r-ferrier
r-ferrier approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@r-ferrier r-ferrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so we can test on staging

@ivan-kocienski-gfsc ivan-kocienski-gfsc merged commit 6b2873a into main Jan 18, 2024
2 checks passed
@ivan-kocienski-gfsc ivan-kocienski-gfsc deleted the ik-2162-nuking-gems-again branch January 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-ferrier r-ferrier r-ferrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused gems
2 participants
@ivan-kocienski-gfsc @r-ferrier