Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hopefully fix deployment workflows #1523

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Hopefully fix deployment workflows #1523

merged 3 commits into from
Nov 2, 2022

Conversation

erbridge
Copy link
Contributor

@erbridge erbridge commented Nov 2, 2022

Relates to #1522

@erbridge erbridge added the chore label Nov 2, 2022
@erbridge erbridge enabled auto-merge (squash) November 2, 2022 10:38
ivan-kocienski-gfsc
ivan-kocienski-gfsc approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

kimadactyl
kimadactyl approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@kimadactyl kimadactyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit nervous about changing staging deploys now it's working but trusting the process!

@kimadactyl kimadactyl linked an issue Nov 2, 2022 that may be closed by this pull request
[Bug]: Production isn't deploying #1522
Closed
@erbridge erbridge removed a link to an issue Nov 2, 2022
[Bug]: Production isn't deploying #1522
Closed
@erbridge erbridge linked an issue Nov 2, 2022 that may be closed by this pull request
[Bug]: Production isn't deploying #1522
Closed
@erbridge erbridge merged commit 2c909bb into main Nov 2, 2022
@erbridge erbridge deleted the 1522/better-workflows branch November 2, 2022 10:42
@erbridge
Copy link
Contributor Author

erbridge commented Nov 2, 2022

If we change staging to match, we give ourselves more confidence in production. My theory here (which I should have written in the commits) is that the workflow runs "from" the default branch, so doesn't meet the condition to run from production, despite being triggered by a workflow run for the production branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimadactyl kimadactyl kimadactyl approved these changes

@ivan-kocienski-gfsc ivan-kocienski-gfsc ivan-kocienski-gfsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Production isn't deploying
3 participants
@erbridge @kimadactyl @ivan-kocienski-gfsc