Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate partners on partner index pages #1432

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Fix duplicate partners on partner index pages #1432

merged 2 commits into from
Aug 16, 2022

Conversation

ivan-kocienski-gfsc
Copy link
Contributor

Implements #1427

@github-actions github-actions bot added bug Release Drafter category - bug impacting the normal functioning of existing features patch Bump version 0.0.X labels Aug 15, 2022
@aaaaargZombies
Copy link
Contributor

Tests run on my machine, manual testing by visiting the effected page showed no sign of the issue. I will start having a read of the code with the docs open so I can get an idea of whats going on. But as far as I can tell LGTM

aaaaargZombies
aaaaargZombies approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@aaaaargZombies aaaaargZombies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaaaargZombies
Copy link
Contributor

I'd be tempted to change the title from "Bug" to "Fix" but this is probably a matter of taste

@kimadactyl
Copy link
Member

For this repo the idea is that they're sentances that can go straight into release notes but I don't think this is written down anywhere yet!

@kimadactyl kimadactyl changed the title Bug: partners duplicated on sites index Fix duplicate partners on partner index pages Aug 16, 2022
@kimadactyl kimadactyl linked an issue Aug 16, 2022 that may be closed by this pull request
[Bug]: partners showing up multiple times on same page #1427
Closed
3 tasks
@kimadactyl kimadactyl merged commit a1aadba into main Aug 16, 2022
@kimadactyl kimadactyl deleted the ik-1427-repeat-partner-on-site-bug branch August 16, 2022 12:31
@kimadactyl
Copy link
Member

Screenshot 2022-08-22 at 12 18 58

Confirmed working on staging - i reproduced the record and this seems to be because it had 3 service areas set it was showing up 3 times

@kimadactyl
Copy link
Member

Oh crap. It's not respecting the tag filter at all now. I assumed this was a staging situation but... it is not. My bad for breaking this but we need this fixed asap...

Screenshot 2022-08-22 at 13 00 19

ivan-kocienski-gfsc pushed a commit that referenced this pull request Aug 22, 2022
@ivankocienski
Revert "Fix duplicate partners on partner index pages (#1432)"
2bb2489 
This reverts commit a1aadba.
kimadactyl added a commit that referenced this pull request Aug 22, 2022
@kimadactyl
Merge pull request #1438 from geeksforsocialchange/ik-filter-revert
9e2e4d4 
Revert "Fix duplicate partners on partner index pages (#1432)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaaaargZombies aaaaargZombies aaaaargZombies approved these changes

Assignees
No one assigned
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features patch Bump version 0.0.X
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: partners showing up multiple times on same page
4 participants
@ivan-kocienski-gfsc @aaaaargZombies @kimadactyl @ivankocienski