support for first upload.

Fail if chrome/chromium is not found
geeklearningio · Jul 29, 2018 · 3060a47 · 3060a47
1 parent ca3d2d1
commit 3060a47
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/Tasks/GhostThemeUploader/ghostThemeUploaderTask.ts b/Tasks/GhostThemeUploader/ghostThemeUploaderTask.ts
@@ -38,7 +38,8 @@ async function themeUpload() {
     }
 
     if (!chromium) {
-        throw new Error('Chromium was not found. Please install it');
+        tl.setResult(tl.TaskResult.Failed, 'Chromium was not found. Please install it');
+        return;
     }
 
     const browser = await puppeteer.launch({ executablePath: chromium });
@@ -80,9 +81,16 @@ async function themeUpload() {
         await themeUpload.uploadFile(themePath);
         await takeScreenshot(page, 'theme.file.png');
 
-        await page.waitFor('button.gh-btn-red');
-        await page.click('button.gh-btn-red');
-        await takeScreenshot(page, 'theme.uploading.png');
+        try {
+            // if overwrite message
+            await page.waitFor('button.gh-btn-red', { timeout: 1000 });
+
+            await page.click('button.gh-btn-red');
+            await takeScreenshot(page, 'theme.uploading.png');
+        }
+        catch (err) {
+
+        }
 
         await page.waitForXPath("//h1[contains(.,'Upload successful!')]", { timeout: uploadTimeout * 1000 })
         await takeScreenshot(page, 'complete.png');
@@ -98,7 +106,7 @@ async function themeUpload() {
 
     } finally {
         browser.close();
-        
+
         if (takeScreenshotsEnabled) {
             let data = {
                 artifacttype: "container",