commander: Silence expected deprecation warnings #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to use the deprecated API because it is the only way to fetch the correct information from menus that were themselves created with that deprecated API, so we don't care about deprecation here. Closes geany#865
|
@b4n do we want to merge this or carry it around for yet another release cycle? :) |
|
Yeah let's get it in not to have other people waste time trying to "fix" it. This won't remove all deprecation warnings (the plugin still uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to use the deprecated API because it is the only way to fetch the correct information from menus that were themselves created with that deprecated API, so we don't care about deprecation here.
Closes #865, and see there for details.