vimode: Don't use word navigation from Scintilla #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works well!, I did find one very specific issue though, the cursor will no go back (b) to the very first character of the very first line. |
Scintilla does different things when using SCI_WORDRIGHT, SCI_WORDLEFT, SCI_WORDRIGHTEND and SCI_WORDLEFTEND than what we want for commands like "w", "b", "W", "B", "e", "E", "ge", "gE". For instance, for ident1 = id|ent2+ident3; where | represents the cursor, SCI_WORDRIGHT does ident1 = ident2+|ident3; while Vim's "w" does ident1 = ident2|+ident3; For this reason we have to reimplement all the word navigation by ourselves to better emulate the behavior of Vim. This patch tries to do that.
|
Should be fixed now. I've also rewritten the patch to make it more maintainable and moved the code to a separate file. |
|
Seems good to me, thanks for doing this by the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scintilla does different things when using SCI_WORDRIGHT, SCI_WORDLEFT,
SCI_WORDRIGHTEND and SCI_WORDLEFTEND than what we want for commands like
"w", "b", "W", "B", "e", "E", etc. For instance, for
ident1 = id|ent2+ident3;
where | represents the cursor, SCI_WORDRIGHT does
ident1 = ident2+|ident3;
while Vim's "w" does
ident1 = ident2|+ident3;
For this reason we have to reimplement all the word navigation by ourselves
to better emulate the behavior of Vim. This patch tries to do that.
Should fix #909