GeanyNumberedBookmarks: Fix crash on re-unload #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unloading the plugin properly remove the GObject data it has set on documents. This avoids leaving dangling pointers to freed memory a subsequent re-loading of the plugin will try and use, leading to a crash. Fixes geany#803.
This should not be a problem so long as the plugin library is actually unloaded, but would be a problem if the module was resident, which is handy for debugging. So, properly reset the variable to NULL after free for it to still have a sane value afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to load the plugin, unload it, everything's fine. Re-load it, and unload it. Boom 💥. It probably also crashes when being used after second load.