projectorganizer: Use stock icons instead of the ones provided by the plugin #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugin I used to ship toolbar icons with the plugin to be sure they are correct semantically. For instance, the "+" icon is used to expand the tree and the semantics of the corresponding icon in GTK is "add" - some crazy theme could for instance use word "ADD" in the icon and then the icon wouldn't correspond to the "expand" meaning. However, I've just been playing with many icon themes on OS X and they display these basic icon in more or less the same way so using stock icons seems to be relatively safe. This also solves the problem of the shipped icon being displayed in a different way than the rest of the system icons and in addition, if HiDPI icons are available, they can be used on a highres monitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used to ship toolbar icons with the plugin to be sure they are correct semantically.
For instance, the "+" icon is used to expand the tree and the semantics of the
corresponding icon in GTK is "add" - some crazy theme could for instance use
word "ADD" in the icon and then the icon wouldn't correspond to the "expand"
meaning.
However, I've just been playing with many icon themes on OS X and they display
these basic icon in more or less the same way so using stock icons seems to be
relatively safe. This also solves the problem of the shipped icon being displayed
in a different way than the rest of the system icons and in addition, if HiDPI icons
are available, they can be used on a highres monitor.