Fix crash in projectorganizer's crash-fix #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he tree Since expand_on_idle() is called as an idle function, it can happen it's executed after project is closed. Before trying to expand paths it now first checks if the idle call corresponds to the project for which the idle call was created. Should fix crash reported in geany#549.
The previous code only checked this for paths shown in the sidebar but since the plugins also tries to perform the expansion for the current document when this option is enabled, it needs to be done for this case as well. Just leave the function when prj_org == NULL.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, yeah, there was a NULL check missing in the previous pull request. No make it clear what has changed I kept the previous patch and added another patch which fixes the crash when no project is open.