lineoperations: fixed -Werror=aggregate-return #517
Conversation
|
Weird that Travis breaks for perfectly valid code. |
|
I think -Werror=aggregate-return is too aggressive and shouldn't be used. I run into the same problem in geany/geany#1263 where some some functions in ctags return MIOPos which is a tiny structure. I'll prepare a patch to remove this flag from the build - this pull request will then be unnecessary. |
|
Created #529. Depending whether it's OK the first patch from this pull request could be dropped. The second is still necessary as build fails without it. |
lineoperations/src/lineoperations.c
Outdated
| gint num_chars = 0; | ||
| gint i = 0; | ||
| gint lines_affected = 0; | ||
|
|
||
| struct lo_lines *sel = g_malloc(sizeof(struct lo_lines)); |
There was a problem hiding this comment.
instead of allocating on the heap you could pass &sel to the get_current_sel_lines() call below
lineoperations/src/lineoperations.c
Outdated
| @@ -223,18 +227,26 @@ action_sci_manip_item(GtkMenuItem *menuitem, gpointer gdata) | |||
| /* function pointer to gdata -- function to be used */ | |||
| gint (*func)(ScintillaObject *, gint, gint) = gdata; | |||
| GeanyDocument *doc = document_get_current(); | |||
| struct lo_lines sel = get_current_sel_lines(doc->editor->sci); | |||
|
|
|||
| struct lo_lines *sel = g_malloc(sizeof(struct lo_lines)); | |||
|
Thanks for all the input, guys. |
|
@smostertdev For now I prefer not returning aggregates, but it's really your call as I can't really back my opinion up with facts right now, and @elextr and @codebrainz seem happy about it. |
|
@b4n I'm indifferent, I just mentioned that it's legal code. |
|
@b4n, the more its discussed the more convinced I become that returns of small values via pointer parameters instead of the function return value is ugly and inefficient. It limits the benefits of inlining and defeats the compiler's ability to employ copy elision and requires the caller to explicitly declare a variable. GCC's |
Functions no longer work with structure, instead pointer to structure.
Items are added with ui_add_document_sensitive so doc is never null.
smostertdev
force-pushed
the
lineoperations_v3
branch
from
83cab98 to
c4de252
Compare
|
@codebrainz @b4n How going on here? |
|
@b4n Please review as soon as you have some spare time. Will postpone it to another release |
|
@b4n Ping ;) |
|
@frlan, be patient, your previous ping isn't quite a year ago yet :) |
|
LGBI |
Oops, I think I broke Travis CI.
I am returning a (small) structure when I should be using pointers.
This commit should fix this mess, my apologies.