Various and small geanygdb fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't introduce any feature change and only one effective code change on a tricky (but not strictly speaking wrong) spot.
strtoull() is a C99 function and the result was stored in an int anyway, so use strtoul() instead.
ghost
assigned
dmaphy
added a commit
that referenced
this pull request
Jun 9, 2012
Various and small geanygdb fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now is the turn of GeanyGDB in the great Spring Cleanup :)
The patches here fixes various GCC warnings and makes the plugin more C89-compliant (although it still uses
snprintf()and various POSIX API).I'll ping @dmaphy for him to review those too since he's the maintainer of that plugin according to the MAINTAINERS file; but I do the PR here because he doesn't have his own fork.