projectorganizer: Use the word "symbol" instead of "tag" #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -620,7 +620,7 @@ gint prjorg_project_add_properties_tab(GtkWidget *notebook) | |||
| gtk_entry_set_text(GTK_ENTRY(e->ignored_dirs_patterns), str); | |||
| g_free(str); | |||
|
|
|||
| label = gtk_label_new(_("Generate tags for all project files:")); | |||
| label = gtk_label_new(_("Parse symbols for all project files:")); | |||
There was a problem hiding this comment.
I'm not sure if the new sentence is correct. I'd rather say Parse symbols in all project files or from rather than for. @elextr ?
There was a problem hiding this comment.
Yeah, and actually we don't want to "parse symbols" but rather files. I'd just simplify it to "Index all project files"
|
Otherwise, LGTM |
techee
force-pushed
the
tags_are_symbols
branch
from
a0425bf to
9d65e1f
Compare
| gtk_misc_set_alignment(GTK_MISC(label), 0, 0); | ||
| e->generate_tag_prefs = gtk_combo_box_text_new(); | ||
| gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(e->generate_tag_prefs), _("Auto (generate if less than 300 files)")); | ||
| gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(e->generate_tag_prefs), _("Auto (index if less than 300 files)")); |
There was a problem hiding this comment.
BTW, it says 300 here, but 500 in the docs.
|
@b4n Thanks, fixed. As the linguistic problem disappeared because I renamed the label, I guess the patch is OK now so merging. |
techee
added a commit
that referenced
this pull request
Feb 18, 2016
projectorganizer: Use the word "symbol" instead of "tag"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the same for ProjectOrganizer as for Geany in geany/geany#582