Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove waf as build system from Geany-Plugins #311

Merged
merged 6 commits into from
Jan 6, 2016

Conversation

frlan
Copy link
Member

@frlan frlan commented Nov 21, 2015

This pull request will purge support waf from geany-plugins.

@frlan frlan added the waf label Nov 21, 2015
@frlan frlan added this to the 1.27 milestone Nov 21, 2015
@eht16
Copy link
Member

eht16 commented Nov 29, 2015

LGTM.
Only a few things are left in .gitignore:

diff --git a/.gitignore b/.gitignore
index d9d046e..4f6e957 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,7 +22,6 @@ cscope.files
 #-----------------------------------------------------------------------
 /aclocal.m4
 /autom4te.cache
-/_build_
 /build/*.pyc
 /build/cache
 /build-aux/
@@ -44,7 +43,6 @@ cscope.files
 /intltool-*
 /libtool
 /localwin32.mk
-/.lock-wscript
 /ltmain.sh
 /m4/
 /make_deb.sh
@@ -57,9 +55,6 @@ cscope.files
 /*.tar.*
 /test-driver
 /TODO.*
-/.waf-*
-/.waf3-*
-.lock-waf*

 #-----------------------------------------------------------------------
 # /po/

@frlan
Copy link
Member Author

frlan commented Nov 29, 2015

As they are not conflicting anything I wanted to leave them in until >1.27 so current checkouts wont add it by accident.

@eht16
Copy link
Member

eht16 commented Nov 30, 2015

Ok. In geany/geany#769 I cleaned .gitignore already. But yes, it won't hurt to delay this step until post 1.27.

frlan added a commit that referenced this pull request Jan 6, 2016
Remove waf as build system from Geany-Plugins
@frlan frlan merged commit efeddb9 into geany:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants