Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope: Don't use an untrusted string as a printf format #286

Merged
merged 1 commit into from
Oct 2, 2015

Conversation

b4n
Copy link
Member

@b4n b4n commented Oct 2, 2015

Reported by GCC's -Wformat-security.

Reported by GCC's `-Wformat-security`.
@b4n
Copy link
Member Author

b4n commented Oct 2, 2015

Found through nightly builds (http://nightly.geany.org/):

debug.c: In function 'debug_parse':
debug.c:256:4: error: format not a string literal and no format arguments [-Werror=format-security]
    dc_error(error);
    ^

@zhekov
Copy link
Member

zhekov commented Oct 2, 2015

Thanks. Merged.

zhekov added a commit that referenced this pull request Oct 2, 2015
scope: Don't use an untrusted string as a printf format
@zhekov zhekov merged commit f5e09d7 into geany:master Oct 2, 2015
@zhekov
Copy link
Member

zhekov commented Oct 2, 2015

(though the only values of error are currently "binary zero encountered" and "line too long or incomplete")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants