Fix missing translations #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing config.h includes lead to missing GETTEXT_PACKAGE and then to `_()` not to do anything useful.
| gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(s_ft_dialog.combo_match), "pattern"); | ||
| gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(s_ft_dialog.combo_match), _("exact")); | ||
| gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(s_ft_dialog.combo_match), _("prefix")); | ||
| gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(s_ft_dialog.combo_match), _("pattern")); |
There was a problem hiding this comment.
@techee please quickly check these, as they are in one of your plugins :)
There was a problem hiding this comment.
I'm not techee but I'd be fine of merging this ;)
There was a problem hiding this comment.
I am techee and I'm fine with merging this too :-). Thanks for noticing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix actually translating some strings marked as translatable (in addons/wrapword and tableconvert). Overview has a similar problem but I opened codebrainz/overview-plugin#15 to please @codebrainz :)
Also, mark a few more visible strings as translatable. This is harmless for the string freeze, as the strings weren't translatable at all anyway, so while they are technically new in the translations they aren't new in the code. Maybe this could also warrant an update of the PO file as we are early in the freeze, so hopefully some translators will get the update version and the 6 additional strings.