Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons: support for URI's containing ~ and + #238

Closed
wants to merge 1 commit into from
Closed

addons: support for URI's containing ~ and + #238

wants to merge 1 commit into from

Conversation

glitsj16
Copy link
Contributor

Better current word selection for URI's containing ~ and/or +. By adding ~ and + to GEANY_WORDCHARS URI's from launchpad.net (and others) get selected (and opened) correctly. Otherwise these get cut at the tilde character.

Example: https://launchpad.net/~geany-dev/+archive/ubuntu/ppa gets selected as https://launchpad.net/

Better current word selection for URI's containing ~ and/or +. By adding ~ and + to GEANY_WORDCHARS URI's from launchpad.net (and others) get selected (and opened) correctly. Otherwise these get cut at the tilde character.

Example: https://launchpad.net/~geany-dev/+archive/ubuntu/ppa gets selected as https://launchpad.net/
@eht16
Copy link
Member

eht16 commented Jun 19, 2015

The changes look fine to me. Only a more descriptive commit message would be cool.

@glitsj16 glitsj16 changed the title Update ao_openuri.c Add support for URI's containing ~ and + to 'Open and Copy URI commands' Jun 19, 2015
@glitsj16
Copy link
Contributor Author

Updated descriptive commit message.

@b4n
Copy link
Member

b4n commented Jun 19, 2015

@glitsj16 you only updated the PR's title, not the commit's message :) To update the commit message, use git commit --amend, and then replace the commit on this PR with git push -f glitsj16 master.
BTW, tip: next time, don't commit on branch master, always create a separate branch to work on some changes (git checkout -b my-feature-branch), as this will prevent your own master from diverging from geany-plugins's master.

Otherwise, LGTM

@glitsj16 glitsj16 changed the title Add support for URI's containing ~ and + to 'Open and Copy URI commands' addons: support for URI's containing ~ and + Jun 19, 2015
@b4n
Copy link
Member

b4n commented Jun 22, 2015

replaced by #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants