Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks for openpty() on FreeBSD #210

Merged
merged 2 commits into from
Apr 12, 2015
Merged

Fix checks for openpty() on FreeBSD #210

merged 2 commits into from
Apr 12, 2015

Conversation

b4n
Copy link
Member

@b4n b4n commented Apr 6, 2015

FreeBSD has openpty() in libutil.h.

I PR this because while the Waf changes work, they might be deemed ugly. @eht16 if you have a better version for this it'd be welcome :) Otherwise they are OK enough with me.

@techee
Copy link
Member

techee commented Apr 7, 2015

Just tested on OS X - works fine here.

"""
headers = kw.get('header_name')
mandatory = kw.get('mandatory', True)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both kwargs are passed explicitly to check_cc() below, we probably should .pop() them from the dict to not pass them twice to check_cc()

@eht16
Copy link
Member

eht16 commented Apr 9, 2015

Except the both code comments this looks fine to me. Why did you think it would be that ugly? 😄

@b4n
Copy link
Member Author

b4n commented Apr 10, 2015

@eht16

I updated the commit to address your remarks. Looks way better now indeed :)

Why did you think it would be that ugly?

Well, a combination of what your remarks fixed, and that I don't find it particularly clean to try…except in the loop just to re-raise the exception if the loop exited. But I couldn't really find another way to do this, and it works, so it might be good enough ^^

@eht16
Copy link
Member

eht16 commented Apr 12, 2015

I agree on the part that re-raising a remembered exception is not perfectly nice. Still it is ok I guess.
If anyone comes up with a cleaner solution later, we can improve it then as well.

b4n added a commit to b4n/geany-plugins that referenced this pull request Apr 12, 2015
Fix checks for openpty() on FreeBSD
@b4n b4n merged commit 73ae49d into geany:master Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants