Updatechecker improvements - more notifications and setting a timeout #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for updates on program start, also log the results to the status messages to make the result more visible to the user. While at it, changed the wording of a few messages and made the version check URL a constant.
Ten seconds should be enough for this simple request. The default timeout is OS-depent and might be much higher so better set a reasonable value.
frlan
added a commit
that referenced
this pull request
Oct 19, 2014
Updatechecker improvements - more notifications and setting a timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make update check results and notifications more visibile to the user and set a short default timeout for the HTTP request.
Before, the update checker plugin mostly said "yes, updates" or "no updates". Now. it tells also the available version if any and push yes/no messages also to the status messages in case the update check was performed at program start.