vimode: Fix caret position change when performing line operations #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was incorrect. The new code just 1. Goes to the last position in document 2. Goes one position before that 3. Checks if the lines corresponding to (1) and (2) are identical - in this case the NL is missing at EOF
When current position is changed in the document and this position is outside the visibility of the current screen, when returning back, the call of SCI_GOTOPOS causes window scroll to a different position than before. To avoid this problem, insert_eof_nl_if_missing() and remove_char_from_eof() avoid setting the position now and, instead, insert/remove the EOL character using operations that don't change caret position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the problem related to caret position change reported in #1136.