Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typedoc and typescript, refactor plugin to work with typedoc 0.22.0+ #19

Closed
wants to merge 1 commit into from

Conversation

nlfurniss
Copy link

Fixes #18

@mjvmroz
Copy link

mjvmroz commented Oct 8, 2021

This is the second time in two days that I've started working on a fix for a tool I'm using only to find that someone has already done it and raised a PR in the past 24 hours. Thanks for making me feel good about the world 😍

@nlfurniss
Copy link
Author

@gdelmas when you have some time can you review?

@ToxesFoxes
Copy link

ToxesFoxes commented Jan 18, 2022

How soon will it be fixed? Without this plugin you can't add source links😄

@nlfurniss
Copy link
Author

How soon will it be fixed? Without this plugin you can't add source links😄

I don’t think this will ever be merged and released, so I forked the repo with the changes.

https://github.com/nlfurniss/typedoc-plugin-sourcefile-url

@gdelmas
Copy link
Owner

gdelmas commented Jan 24, 2022

as i am no longer using this plugin myself, and am quite limited on time, i would be happy for somebody to take over maintenance. have you published updated versions to npm? happy to look into how to transfer the ownership, if you are willing to maintain the plugin.

@nlfurniss
Copy link
Author

as i am no longer using this plugin myself, and am quite limited on time, i would be happy for somebody to take over maintenance. have you published updated versions to npm? happy to look into how to transfer the ownership, if you are willing to maintain the plugin.

Sure would be happy to. I published my fork to NPM

@ThisIsMissEm
Copy link

@nlfurniss looks like the plugin is broken again as of typedoc 0.23.2 due to:

Removed ProjectReflection.files, this was an internal cache that should not have been exposed, and shouldn't have existed in the first place, since removing it made TypeDoc faster.

I'm not sure how to resolve that?

@nlfurniss nlfurniss closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin typedoc-plugin-sourcefile-url could not be loaded
5 participants