Hyperlink support (OSC 8) and performance fixes #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #526 tcell emits redundant attributes This work is inspired by, and partly derived from, work submitted by Simon Ser (@emersion). However, we've modified the bottom half of the terminfo parser to better support strings properly, and are using proper terminfo syntax. Instead of an attribute called Hyperlink, we have called it Url for the sake of brevity. While here we noticed and fixed bug #526, which could badly impact slow terminals, or slow links. This likely makes things better for folks coming over long distance SSH connections for example. We've also provided OSC 8 handling for all terminals which appear to support the mouse sequences; hopefully ones that don't handle this sensibly will just ignore it. (Limited testing seems to show this.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.