Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the structure TreeSet #70

Closed
wants to merge 1 commit into from
Closed

Conversation

amontoison
Copy link
Collaborator

Related to #68

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (cb1c2c6) to head (c8400b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   99.83%   99.81%   -0.02%     
==========================================
  Files          11       10       -1     
  Lines         605      552      -53     
==========================================
- Hits          604      551      -53     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Owner

gdalle commented Aug 12, 2024

This is superseded by the result type refactor in #71.
I put the complexity in the result constructors rather than the TreeSet, that way we can still have a fast underlying coloring if we want to.

@amontoison amontoison closed this Aug 12, 2024
@gdalle gdalle deleted the smarter_decompression branch August 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants