Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for structured matrices #137

Merged
merged 30 commits into from
Oct 4, 2024
Merged

Add tests for structured matrices #137

merged 30 commits into from
Oct 4, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Oct 3, 2024

Add some tests (no custom implementations yet) for the following structured matrix types.

Package Type Coloring Decompression Performance
LinearAlgebra Diagonal
LinearAlgebra Bidiagonal
LinearAlgebra Tridiagonal
BandedMatrices BandedMatrix
BlockBandedMatrices BlockBandedMatrix
BlockBandedMatrices BandedBlockBandedMatrix

The fallback decompression already works without error: it follows the sparsity pattern, so it avoids writing into forbidden locations (say, outside of the diagonal for a Diagonal).

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1cb3884) to head (61da959).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          871       871           
=========================================
  Hits           871       871           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit c28490d into main Oct 4, 2024
7 checks passed
@gdalle gdalle deleted the gd/structured2-test branch October 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants