Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ConstantColoringAlgorithm #127

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Implement ConstantColoringAlgorithm #127

merged 2 commits into from
Sep 27, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Sep 27, 2024

  • Add a new ConstantColoringAlgorithm which always returns the same ColumnColoringResult or RowColoringResult (fix Implement coloring when the color vector is known #124)
  • Make sure it errors when it is used inappropriately (wrong type of coloring, wrong matrix shape)
  • Document and test it properly

@gdalle gdalle requested a review from amontoison September 27, 2024 21:49
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (580cc45) to head (a86fbf8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          829       855   +26     
=========================================
+ Hits           829       855   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 1d64277 into main Sep 27, 2024
7 checks passed
@gdalle gdalle deleted the gd/constantcoloringalgo branch September 27, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement coloring when the color vector is known
1 participant