Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sparse(A) with convert(SparseMatrixCSC, A) #112

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Sep 26, 2024

When A is already a SparseMatrixCSC, calling sparse(A) makes a useless copy, while convert(SparseMatrixCSC, A) doesn't. The behavior in other cases seems identical.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cbce39f) to head (9afb47a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          764       764           
=========================================
  Hits           764       764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 1abd62e into main Sep 26, 2024
7 checks passed
@gdalle gdalle deleted the gd/convert branch September 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants