Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 21/extends issue 22 user registration login #56

Conversation

TekuriSaiAkhil
Copy link
Collaborator

@TekuriSaiAkhil TekuriSaiAkhil commented Oct 6, 2024

Issue 21 + Issue 22

Description

  • Implemented User Registration
  • Implemented User Login
  • Added Login with Google

Change Type (delete non-relevant options)

  • 💡 New feature (non-breaking change which adds functionality)

Dependencies

  • To try this out locally:
  1. Activate your virtual env and install all dependencies in requirements.txt
  2. add a .env file to src/
  3. cd src
  4. python manage.py makemigrations
  5. python manage.py migrate
  6. [optional] python manage.py createsuperuser
  7. python manage.py runserver

Copy link
Collaborator

@maxgrove42 maxgrove42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're failing the linting checks, which are used to ensure clean code styles. If you go to the Pull Request, then the Checks tab, you'll see the two checks. One for Lint and one for Branch Name Check.

In order for the pull request to be merge-able, it needs to pass all the linting checks. You can also run the linting locally using the instructions in the README file.

src/accounts/views.py Outdated Show resolved Hide resolved
@maxgrove42
Copy link
Collaborator

Really great work with this. having less setup and using environment keys makes it much more fluid to deploy. Very impressive. A few small nits on my end but seriously great work

src/accounts/backends.py Outdated Show resolved Hide resolved
src/accounts/views.py Outdated Show resolved Hide resolved
src/accounts/views.py Outdated Show resolved Hide resolved
src/accounts/views.py Outdated Show resolved Hide resolved
src/accounts/views.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@maxgrove42 maxgrove42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits re: comments / linter

@TekuriSaiAkhil TekuriSaiAkhil self-assigned this Oct 8, 2024
@TekuriSaiAkhil TekuriSaiAkhil added this to the Sprint 04 milestone Oct 8, 2024
@maxgrove42
Copy link
Collaborator

maxgrove42 commented Oct 8, 2024

Approved. Please use squash and merge when you get a second review! It's on the drop down of the Create a Merge Commit button. Keeps the develop branch commit history clean!

Screenshot 2024-10-08 at 5 14 14 PM

Copy link
Collaborator

@arsalananwar11 arsalananwar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Akhil!

src/accounts/forms.py Show resolved Hide resolved
@TekuriSaiAkhil TekuriSaiAkhil merged commit 76c93e3 into develop Oct 8, 2024
2 checks passed
@maxgrove42 maxgrove42 deleted the feature/issue-21/extends-issue-22-user_registration_login branch October 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants