-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 21/extends issue 22 user registration login #56
Feature/issue 21/extends issue 22 user registration login #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're failing the linting checks, which are used to ensure clean code styles. If you go to the Pull Request, then the Checks
tab, you'll see the two checks. One for Lint
and one for Branch Name Check
.
In order for the pull request to be merge-able, it needs to pass all the linting checks. You can also run the linting locally using the instructions in the README
file.
Really great work with this. having less setup and using environment keys makes it much more fluid to deploy. Very impressive. A few small nits on my end but seriously great work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits re: comments / linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks Akhil!
Issue 21 + Issue 22
Description
Change Type (delete non-relevant options)
Dependencies